Re: [PATCH] tests: fix len(contents) for error output, if contents is None

On Thu, 2008-08-21 at 03:53 +0200, Neels Janosch Hofmeyr wrote:
> [[[
> * subversion/tests/cmdline/svntest/tree.py (pprint): Fix failure to get
> len(contents) for error output, for the case that contents is `None'.
> ]]]

Neels, this patch fixes the case where the MIME type is set to something
(but not something beginning with "text/") and content is None. If the
MIME type is set, I don't think it makes sense for the content to be
None. If some caller is setting content to None, maybe the caller is
broken.

There might be some complication, like if the object being represented
is a deleted file, and therefore its content is None, and for some
reason the properties have not been deleted. (There is currently a bug
in Subversion whereby the working properties can still be accessed by
some of svn's property commands when an object is scheduled for
deletion. Maybe that sort of thing is happening here.)

Does that make sense? Did you find a case where this happens?

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-21 13:03:13 CEST