[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32360 - trunk/subversion/libsvn_repos

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 04 Aug 2008 10:13:05 -0400

stsp_at_tigris.org wrote:
> Author: stsp
> Date: Mon Aug 4 03:14:02 2008
> New Revision: 32360
> Log:
> Fix a bug causing mod_dav_svn to eat all memory during a merge
> operation when SVNPathAuthz is set to 'short_circuit'.
> According to the reporter, this bug is only triggered when
> using a 1.5 client.
> * subversion/libsvn_repos/rev_hunt.c
> (svn_repos_node_location_segments): authz_read requires that
> its path argument starts with a leading slash, so make sure
> the path passed to authz_read starts with '/'.

You know, if authz_read requires as much, I would *strongly* suggest having
that function (or at least the implementations thereof which we provide)
assert that the input is valid, perhaps using Julian's new
assert-is-sometimes-an-error macro.

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2008-08-04 16:13:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.