[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32360 - trunk/subversion/libsvn_repos

From: Stefan Sperling <stsp_at_elego.de>
Date: Mon, 4 Aug 2008 16:55:38 +0200

On Mon, Aug 04, 2008 at 10:13:05AM -0400, C. Michael Pilato wrote:
> stsp_at_tigris.org wrote:
> > Author: stsp
> > Date: Mon Aug 4 03:14:02 2008
> > New Revision: 32360
> >
> > Log:
> > Fix a bug causing mod_dav_svn to eat all memory during a merge
> > operation when SVNPathAuthz is set to 'short_circuit'.
> > According to the reporter, this bug is only triggered when
> > using a 1.5 client.
> >
> > * subversion/libsvn_repos/rev_hunt.c
> > (svn_repos_node_location_segments): authz_read requires that
> > its path argument starts with a leading slash, so make sure
> > the path passed to authz_read starts with '/'.
> You know, if authz_read requires as much, I would *strongly* suggest having
> that function (or at least the implementations thereof which we provide)
> assert that the input is valid, perhaps using Julian's new
> assert-is-sometimes-an-error macro.

Oh, absolutely, exactly my thoughts.
In fact, I've already proposed doing this in IRC while you
weren't around :)

I have no time right now to do that, though. Can you do it?
Otherwise I'll keep it on my mental TODO list, or even better
open an issue in the tracker.

Note that the docstring of the callback in svn_repos.h does
not mention this restriction either, so we'll probably want to patch
the docs as well.
Thereby possibly restricting public API semantics retroactively... :-/


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-04 16:55:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.