Re: bug: invalid svn:keywords silently ignored

Karl Fogel wrote:
>
> "David Glasser" <glasser_at_davidglasser.net> writes:
> > On Tue, Jun 24, 2008 at 11:47 AM, <jklowden_at_schemamania.org> wrote:
> >> In svn_subst_build_keywords2, no message is produced if a token in
> >> keywords_val has no meaning to svn:keywords. The result is that
> >mispelled > or mis-delimited keywords are silently ignored, leading to
> >mysterious > behavior.
> >
> > This is a good point. The one corner case to worry about is
> > compatibility: if we add your fix in 1.6 and introduce a new keyword
> > in 1.7, should we make it impossible to add that keyword to
> > svn:keywords with a 1.6 client?

If you're asking me, I would say that's OK.

1. The keyword domain expands very slowly, if at all. CVS was around for
a long time with a stable list of them.

2. There aren't that many attributes that make sense to use in this way.
It's very hard to imagine the hot new keyword of 2009.

3. Upgrading the client isn't difficult.

Please bear in mind that the whole property-setting feature is pretty hard
to grasp. Lack of validated input only makes it harder to get right.

Regards,

--jkl (not subscribed)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-25 08:04:24 CEST