Re: Bugreport for subversion

Karl Fogel wrote:
> Anders Kvist <kvist_at_cego.dk> writes:
>> I just upgraded to newest release, 1.5.0 and had some problems with 'svn
>> log --xml'. Also tried the latest trunk (31863).
>>
>> We have an older server serving subversion via web_dav, running
>> subversion 1.1.0.
>>
>> When doing a 'svn log --limit 10 --xml http://path/to/repo', i always
>> get two </logentry> at the bottom of the output.
>>
>> <?xml version="1.0"?>
>> <log>
>> <logentry
>> revision="REVISION_REMOVED">
>> <author>USER_REMOVED</author>
>> <date>TIME_REMOVED</date>
>> <msg>"TEXT_REMOVED"</msg>
>> </logentry>
>> </logentry>
>> </log>
>>
>> After a bit of debugging, I found out that it was caused in
>> ./subversion/svn/log-cmd.c on line 334 (newest trunk - revision 31863).
>> Apparently the last log_entry->revision is -1 and causing it to fail.
>>
>> I tried this against other svn repositories, but couldn't make them
>> fail. We've been using a lot of other versions of subversion and never
>> had this problem before.
>>
>> I don't have the knowledge to start debugging more into why this
>> revision -1 appears, but I hope you can help. For now, I have out
>> commented the line, but I guess it's there for a reason :)
>
> I do not have a 1.1 server to test against; can you make yours
> available? Using r31865 of trunk, against a 1.5.0 server, I cannot
> reproduce this:

Googling for "Powered by Subversion version 1.1" yields a number of
candidates for testing.

> $ svn log --limit 10 --xml https://svn.collab.net/repos/svn/trunk
> <?xml version="1.0"?>
> <log>
> <logentry
> revision="31865">
> <author>xsteve</author>
> <date>2008-06-24T16:48:40.538874Z</date>
> <msg>Added compatibility function svn-substring-no-properties
>
> * trunk/contrib/client-side/emacs/psvn.el:
> (svn-substring-no-properties): New function, use
> substring-no-properties when available
> (svn-status-in-vc-mode?, svn-log-resolve-trac-ticket-short): Use
> svn-substring-no-properties
> </msg>
> </logentry>
> <logentry
> revision="31863">
> <author>arfrever</author>
> <date>2008-06-24T11:25:24.445953Z</date>
> <msg>Follow-up to r31862:
>
> * www/svn_1.5_releasenotes.html
> (mt-known-issues): s/&amp;/&amp;amp;/g in URLs.
> </msg>
> </logentry>
> <logentry
> revision="31862">
> <author>arfrever</author>
> <date>2008-06-24T11:14:13.034718Z</date>
> <msg>* www/svn_1.5_releasenotes.html
> (mt-known-issues): Shorten the URL for all merge-related open issues and add
> the URL for issues which have the "merge-tracking" keyword.
> </msg>
> </logentry>
> <logentry
> revision="31861">
> <author>arfrever</author>
> <date>2008-06-24T09:44:02.757076Z</date>
> <msg>Follow-up to r31854:
>
> * subversion/libsvn_auth_kwallet/kwallet.cpp
> (): Include appropriate headers.
> (kwallet_password_get, kwallet_password_set): Restore call to
> KCmdLineArgs::init() and use KAboutData set by KCmdLineArgs to initialize
> KComponentData object.
> </msg>
> </logentry>
> <logentry
> revision="31859">
> <author>cmpilato</author>
> <date>2008-06-23T22:28:22.103092Z</date>
> <msg>Minor tweaks per review of r31820.
>
> * subversion/libsvn_fs_base/tree.c
> (deltify_mutable): Refresh a stale comment.
> (svn_fs_base__deltify): Pass known root node kind into
> deltify_mutable() to avoid an unnecessary lookup.
>
> Suggested by: kfogel,
> brane
> </msg>
> </logentry>
> <logentry
> revision="31858">
> <author>hwright</author>
> <date>2008-06-23T17:16:24.463265Z</date>
> <msg>Take the bold, bold step of postulating when the next few releases will be
> cut.
>
> * www/roadmap.html
> (upcoming-releases): Add a table with (*gasp*) dates for the next few
> releases.
> </msg>
> </logentry>
> <logentry
> revision="31857">
> <author>hwright</author>
> <date>2008-06-23T16:54:37.920014Z</date>
> <msg>A bit of website reorg: Remove 1.5 from the roadmap, and link the correct
> page for previous releases.
>
> * www/roadmap.html
> (upcoming-features): Remove 1.5 section.
> (past-releases): Point to the release history page.
> </msg>
> </logentry>
> <logentry
> revision="31856">
> <author>hwright</author>
> <date>2008-06-23T16:52:59.886183Z</date>
> <msg>A bit of website reorg: Move the list of published releases to
> release-history.html.
>
> * www/project_status.html
> (done): Move from here...
>
> * www/release-history.html:
> ...to here.
> </msg>
> </logentry>
> <logentry
> revision="31855">
> <author>hwright</author>
> <date>2008-06-23T16:42:58.048439Z</date>
> <msg>Fix html validation errors.
>
> * www/index.html
> (want): Remove spurious &lt;/a&gt; tags.
> </msg>
> </logentry>
> <logentry
> revision="31854">
> <author>arfrever</author>
> <date>2008-06-23T14:53:43.543014Z</date>
> <msg>Use KWallet in JavaHL.
>
> * subversion/libsvn_auth_kwallet/kwallet.cpp
> (kwallet_password_get, kwallet_password_set): Use KComponentData instead of
> whole KApplication.
>
> * subversion/bindings/javahl/native/SVNClient.cpp
> (SVNClient::getContext): Use KWallet in JavaHL.
> </msg>
> </logentry>
> </log>
> $

I can reproduce this bug on trunk, and fixed it in r31875. Nominated
for backport to 1.5.x.

-Hyrum