[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: bug: invalid svn:keywords silently ignored

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Tue, 24 Jun 2008 16:15:29 -0400

"David Glasser" <glasser_at_davidglasser.net> writes:
> On Tue, Jun 24, 2008 at 11:47 AM, <jklowden_at_schemamania.org> wrote:
>> In svn_subst_build_keywords2, no message is produced if a token in
>> keywords_val has no meaning to svn:keywords. The result is that mispelled
>> or mis-delimited keywords are silently ignored, leading to mysterious
>> behavior.
> This is a good point. The one corner case to worry about is
> compatibility: if we add your fix in 1.6 and introduce a new keyword
> in 1.7, should we make it impossible to add that keyword to
> svn:keywords with a 1.6 client?

Oh... right... it's all coming back to me now... the sunken ship, the
diamonds... (Sorry, re-using an old sussman joke there.) Yes. We've
had this discussion before, and ran aground on the compatibility issue.

Two possible solutions, not mutually exclusive:

   1. Just display a warning
   2. Prohibit by default, but allow override with --force

I think keyword validation is important enough that it would be better
to use one or both of the solutions above than to do nothing, though.

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-24 22:16:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.