In svn_subst_build_keywords2, no message is produced if a token in
keywords_val has no meaning to svn:keywords. The result is that mispelled
or mis-delimited keywords are silently ignored, leading to mysterious
behavior.
For example, the command:
svn propset svn:keywords Date,Revision,Author,HeadURL,Id *.cpp
(which conforms to common Unix command-line syntax for multi-valued
options) is accepted, but has no effect. The user either doesn't notice,
or wonders whether the feature really works as advertized.
Although properties in general are just key-value pairs with no meaning to
Subversion, a property that Subversion interprets does of course have
a valid domain. The proper course when evaluating any input is to either
accept or reject it, not simply to ignore it and let the user puzzle it out.
Ideally this validation would happen when the property is being stored.
I think perhaps the best place would be svn_wc_prop_set2.
As a second suggestion, it would be nice if the above syntax were supported.
AFAICT the only coding change would be the constant string passed to
svn_cstring_split in svn_subst_build_keywords2.
Would you like me to file a bug report?
--jkl
P.S. I'm not subscribed here. Please cc me to include me in your reply.
-----------------------------------------
The information contained in the linked e-mail transmission and any attachments may be
privileged and confidential and is intended only for the use of the person(s) named in the
linked e-mail transmission. If you are not the intended recipient, or an employee or agent
responsible for delivering this message to the intended recipient, you should not review,
disseminate, distribute or duplicate this e-mail transmission or any attachments . If you
are not the intended recipient, please contact the sender immediately by reply e-mail and
destroy all copies of the original message. We do not accept account orders and/or
instructions related to AllianceBernstein products or services by e-mail, and therefore will
not be responsible for carrying out such orders and/or instructions. The linked e-mail
transmission and any attachments are provided for informational purposes only and should not
be construed in any manner as any solicitation or offer to buy or sell any investment
opportunities or any related financial instruments and should not be construed in any manner
as a public offer of any investment opportunities or any related financial instruments. If
you, as the intended recipient of the linked e-mail transmission, the purpose of which is to
inform and update our clients, prospects and consultants of developments relating to our
services and products, would not like to receive further e-mail correspondence from the
sender, please "reply" to the sender indicating your wishes. Although we attempt to sweep
e-mail and attachments for viruses, we will not be liable for any damages arising from the
alteration of the contents of this linked e-mail transmission and any attachments by a third
party or as a result of any virus being passed on.
Please note:
Trading instructions sent electronically to Bernstein shall not be deemed accepted until a
representative of Bernstein acknowledges receipt electronically or by telephone. Comments in
the linked e-mail transmission and any attachments are part of a larger body of investment
analysis. For our research reports, which contain information that may be used to support
investment decisions, and disclosures, see our website at www.bernsteinresearch.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-24 20:51:20 CEST