[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: bug: invalid svn:keywords silently ignored

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Tue, 24 Jun 2008 15:41:59 -0400

jklowden_at_schemamania.org writes:
> In svn_subst_build_keywords2, no message is produced if a token in
> keywords_val has no meaning to svn:keywords. The result is that mispelled
> or mis-delimited keywords are silently ignored, leading to mysterious
> behavior.
> For example, the command:
> svn propset svn:keywords Date,Revision,Author,HeadURL,Id *.cpp
> (which conforms to common Unix command-line syntax for multi-valued
> options) is accepted, but has no effect. The user either doesn't notice,
> or wonders whether the feature really works as advertized.
> Although properties in general are just key-value pairs with no meaning to
> Subversion, a property that Subversion interprets does of course have
> a valid domain. The proper course when evaluating any input is to either
> accept or reject it, not simply to ignore it and let the user puzzle it out.
> Ideally this validation would happen when the property is being stored.
> I think perhaps the best place would be svn_wc_prop_set2.
> As a second suggestion, it would be nice if the above syntax were supported.
> AFAICT the only coding change would be the constant string passed to
> svn_cstring_split in svn_subst_build_keywords2.

Completely agree with everything you say above.

> Would you like me to file a bug report?

Well, only if you haven't time to post a patch... :-)



To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-24 21:42:32 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.