[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] was Re: Minor nit with Makefile

From: John Peacock <john.peacock_at_havurah-software.org>
Date: Sun, 08 Jun 2008 11:05:34 -0400

Sorry, I had a server outage and one of my MX's was misconfigured, so I didn't
see this response:

> C. Michael Pilato wrote:
> Well, I wonder if the right (as in, "most conservative") thing to do would be:
> check: bin $(TEST_DEPS) @BDB_TEST_DEPS@
> (because 'bin' is the rule that builds 'svn', 'svnadmin', 'svnlook', etc.)
> ?

Yeah, that seems better and it works too!


'make check' should build all binaries if not already built

* Makefile.in
   add 'bin' to check: target of top level Makefile


Index: Makefile.in
--- Makefile.in (revision 31610)
+++ Makefile.in (working copy)
@@ -376,7 +376,7 @@
  # "make check CLEANUP=true" will clean up directories for successful tests.
  # "make check TESTS=subversion/tests/cmdline/basic_tests.py"
  # will perform only basic tests (likewise for other tests).
+check: bin $(TEST_DEPS) @BDB_TEST_DEPS@
         @if test "$(PYTHON)" != "none"; then \
           flags="--verbose"; \
           if test "$(CLEANUP)" != ""; then \

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-08 17:04:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.