Re: [PATCH] was Re: Minor nit with Makefile
Committed in r31656.
John Peacock wrote:
> Sorry, I had a server outage and one of my MX's was misconfigured, so I
> didn't see this response:
>> C. Michael Pilato wrote:
>> Well, I wonder if the right (as in, "most conservative") thing to do
>> would be:
>> check: bin $(TEST_DEPS) @BDB_TEST_DEPS@
>> (because 'bin' is the rule that builds 'svn', 'svnadmin', 'svnlook',
> Yeah, that seems better and it works too!
> 'make check' should build all binaries if not already built
> * Makefile.in
> add 'bin' to check: target of top level Makefile
> Index: Makefile.in
> --- Makefile.in (revision 31610)
> +++ Makefile.in (working copy)
> @@ -376,7 +376,7 @@
> # "make check CLEANUP=true" will clean up directories for successful
> # "make check TESTS=subversion/tests/cmdline/basic_tests.py"
> # will perform only basic tests (likewise for other tests).
> -check: $(TEST_DEPS) @BDB_TEST_DEPS@
> +check: bin $(TEST_DEPS) @BDB_TEST_DEPS@
> @if test "$(PYTHON)" != "none";
> then \
> flags="--verbose"; \
> if test "$(CLEANUP)" != "";
> then \
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Received on 2008-06-09 15:18:11 CEST
This is an archived mail posted to the Subversion Dev