[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH RFC v2] WIN32_RETRY_LOOP on Cygwin

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Fri, 6 Jun 2008 21:16:27 +0300 (Jerusalem Daylight Time)

Bernard Blackham wrote on Sat, 7 Jun 2008 at 01:35 +0800:
> Daniel Shahaf wrote:
> > Branko Œibej wrote on Fri, 6 Jun 2008 at 11:53 +0200:
> > > Daniel Shahaf wrote:
> > > > Branko Œibej wrote on Tue, 27 May 2008 at 12:52 +0200:
> > > >
> > > > > Bernard Blackham wrote:
> > > > >
> > > > > > On Tue, May 27, 2008 at 10:57:18AM +0200, Branko Œibej wrote:
> > > > > > Anyway, new patches are attached for trunk/1.4.6 and 1.4.5 again. As
> > > > > > before, I've only tested the 1.4.5 patch (it's still in the middle
> > > > > > of a multi-gigabyte checkout, but it would usually have failed by
> > > > > > now :)
> > > > > >
> > > > > Looks good. Someone with a Windows box should test this (on
> > > > > both Cygwin and native), but +1 as far as I'm concerned.
> > > > >
> > > > >
> > > > Is anyone able to test this on both cygwin and native Windows?
> > > > (Branko, what do you mean by "testing" --- do you refer to
> > > > running a large checkout or to running 'make check'?)
> > > >
> > > Both, ideally.
> > >
> >
> > Okay. With the former, though, I can't help, since I don't have a multi-GB
> > repository here to test with :(
>
> If you could send me a binary, I'd be (foolishly) quite happy to test it here.
> I just don't have an environment setup to build native Win32 binaries.
>

Hmm. I just looked again at the patch, and it doesn't change the native
(non-cygwin) logic at all -- it only changes the Cygwin-specific logic --
so don't see a need to test it on native (non-cygwin).

Bernard, David, if you can try current trunk under Cygwin and report if
the patch has the intended effect (i.e. works with the patch, fails
without it) it would be great.

Meanwhile, won't we also need a committer with a Cygwin build environment
to commit this change? How do we usually handle Cygwin-specific patches?

> I also tried building trunk under Cygwin but it failed due to a missing
> apr-related symbol which I suspect means I need to update my APR, at which
> point I got nervous about stepping on Cygwin packages and stopped. I will try
> again and persist with that next week. Though again, if there's a statically
> linked Cygwin svn binary, I'd be happy to test it.
>
> Cheers,
> Bernard.
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-06 20:16:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.