[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue 1796: defective or malicious client can corrupt repository log messages

From: Neels Janosch Hofmeyr <neels_at_elego.de>
Date: Tue, 03 Jun 2008 16:40:42 +0200

Stefan Sperling wrote:
> On Tue, Jun 03, 2008 at 09:23:02AM +0300, Daniel Shahaf wrote:
>>> Patch by: Neels Janosch Hofmeyr <neels_at_elego.de>
>>> Review by: Karl Fogel <kfogel_at_red-bean.com>
>>> Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
>>> Stefan Sperling <stsp_at_elego.de>
>>> Branko Čibej <brane_at_xbc.nu>
>> You should list committers by their canonical usernames from HACKING:
>> kfogel, danielsh, stsp, etc.

The examples I found in HACKING are in the style that I wrote them in. I
am far happier to use the tigris usernames!

>> But since you haven't posted a version of
>> this patch before, it is inappropriate to list all these people as
>> reviewers: they haven't reviewed this patch.
> Yes, only people who have reviewed this particular patch should
> be listed. So right now, Daniel is the only one who should be on
> this list.

I see. But how can I credit in a way that shows that a lot of discussion
has been happening? I have also gotten key information by some guys,
without which the patch would've been stupid.

>> If you want to credit
>> the other people than direct reviewers, a parenthetical might work:
>> Review by: jrandom
>> (and here you mention jconstant)
> Daniel, I don't understand at all what you mean by the above...
> What were you trying to say?
Yeah, I don't get this either.

Thanks for the great feedback, Daniel! I'll come up with a second
version of the patch one of these days.

Neels Hofmeyr -- elego Software Solutions GmbH
Gustav-Meyer-Allee 25 / Gebäude 12, 13355 Berlin, Germany
phone: +49 30 23458696  mobile: +49 177 2345869  fax: +49 30 23458695
http://www.elegosoft.com | Geschäftsführer: Olaf Wagner | Sitz: Berlin
Handelsreg: Amtsgericht Charlottenburg HRB 77719 | USt-IdNr: DE163214194

Received on 2008-06-03 16:41:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.