[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue 1796: defective or malicious client can corrupt repository log messages

From: Stefan Sperling <stsp_at_elego.de>
Date: Tue, 3 Jun 2008 09:54:21 +0200

On Tue, Jun 03, 2008 at 09:23:02AM +0300, Daniel Shahaf wrote:
> > Patch by: Neels Janosch Hofmeyr <neels_at_elego.de>
> > Review by: Karl Fogel <kfogel_at_red-bean.com>
> > Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
> > Stefan Sperling <stsp_at_elego.de>
> > Branko ─îibej <brane_at_xbc.nu>
>
> You should list committers by their canonical usernames from HACKING:
> kfogel, danielsh, stsp, etc. But since you haven't posted a version of
> this patch before, it is inappropriate to list all these people as
> reviewers: they haven't reviewed this patch.

Yes, only people who have reviewed this particular patch should
be listed. So right now, Daniel is the only one who should be on
this list.

> If you want to credit
> the other people than direct reviewers, a parenthetical might work:
>
> Review by: jrandom
> (and here you mention jconstant)

Daniel, I don't understand at all what you mean by the above...
What were you trying to say?

Stefan

  • application/pgp-signature attachment: stored
Received on 2008-06-03 09:54:39 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.