[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue 1796: defective or malicious client can corrupt repository log messages

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Tue, 3 Jun 2008 19:41:03 +0300 (Jerusalem Daylight Time)

Neels Janosch Hofmeyr wrote on Tue, 3 Jun 2008 at 16:40 +0200:
> Stefan Sperling wrote:
> > On Tue, Jun 03, 2008 at 09:23:02AM +0300, Daniel Shahaf wrote:
> >>> Patch by: Neels Janosch Hofmeyr <neels_at_elego.de>
> >>> Review by: Karl Fogel <kfogel_at_red-bean.com>
> >>> Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
> >>> Stefan Sperling <stsp_at_elego.de>
> >>> Branko Čibej <brane_at_xbc.nu>
> >> You should list committers by their canonical usernames from HACKING:
> >> kfogel, danielsh, stsp, etc.
> The examples I found in HACKING are in the style that I wrote them in. I
> am far happier to use the tigris usernames!

Stefan added this sentence to HACKING recently:

    Full and partial committers may be listed similarly, but preferably
    by their canonical usernames from COMMITTERS (the leftmost column in
    that file).

And I see an example that uses that syntax. Do you think it could be

> >> But since you haven't posted a version of
> >> this patch before, it is inappropriate to list all these people as
> >> reviewers: they haven't reviewed this patch.
> >
> > Yes, only people who have reviewed this particular patch should
> > be listed. So right now, Daniel is the only one who should be on
> > this list.
> >
> I see. But how can I credit in a way that shows that a lot of discussion
> has been happening? I have also gotten key information by some guys,
> without which the patch would've been stupid.

You don't need to record everyone that participated in the discussions;
that's what list archives are for, link to them.

> >> If you want to credit
> >> the other people than direct reviewers, a parenthetical might work:
> >>
> >> Review by: jrandom
> >> (and here you mention jconstant)
> >
> > Daniel, I don't understand at all what you mean by the above...
> > What were you trying to say?
> Yeah, I don't get this either.


If you want to credit someone specifically, but can't credit them using
the standard fields ("(Review|Suggested|Found) by"), remember that you can
still credit them in the free-text parts of the log message (such as the
parenthetical comments).

Beware of inflation, though. Not every suggestion deserves a log
message entry, for otherwise we'd spend all day bookkeeping, recording
who suggested what...

> Thanks for the great feedback, Daniel! I'll come up with a second
> version of the patch one of these days.


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-03 18:41:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.