Stefan Sperling wrote on Fri, 25 Apr 2008 at 23:03 +0200:
> On Fri, Apr 25, 2008 at 06:18:24AM -0700, arfrever_at_tigris.org wrote:
> > Author: arfrever
> > Date: Fri Apr 25 06:18:24 2008
> > New Revision: 30782
> >
> > Log:
> > On the 'kwallet' branch:
>
> Hey Arfrever,
>
> > + * This is like svn_client_get_simple_provider(), except that the
> > + * password is stored in the KWallet.
>
> Shouldn't this be "stored in Kwallet." ?
>
> > @@ -113,7 +89,7 @@ simple_password_set(apr_hash_t *creds,
> > CREDENTIALS. PASSWORD_GET is used to obtain the password value.
> > PASSTYPE identifies the type of the cached password. CREDENTIALS are
> > allocated from POOL. */
> > -static svn_error_t *
> > +svn_error_t *
> > simple_first_creds_helper(void **credentials,
>
> This function needs some sort of prefix since it's not static
> anymore, doesn't it? Or are the rules for libsvn_subr different?
>
> > @@ -220,7 +196,7 @@ simple_first_creds_helper(void **credent
> > a set of CREDENTIALS to the simple auth provider's username and
> > password cache. PASSWORD_SET is used to store the password.
> > PASSTYPE identifies the type of the cached password. Allocates from POOL. */
> > -static svn_error_t *
> > +svn_error_t *
> > simple_save_creds_helper(svn_boolean_t *saved,
>
> Same here.
>
The other symbols in the header file (password_get_t, password_set_t)
should get a prefix as well.
>
> Thanks,
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-26 12:36:12 CEST