Stefan Sperling wrote on Sat, 26 Apr 2008 at 12:25 +0200:
> On Sat, Apr 26, 2008 at 01:51:19AM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> > 2008-04-25 23:03:17 Stefan Sperling napisaƂ(a):
> > > Shouldn't this be "stored in Kwallet." ?
> > >
> > > > @@ -113,7 +89,7 @@ simple_password_set(apr_hash_t *creds,
> > > > CREDENTIALS. PASSWORD_GET is used to obtain the password value.
> > > > PASSTYPE identifies the type of the cached password. CREDENTIALS are
> > > > allocated from POOL. */
> > > > -static svn_error_t *
> > > > +svn_error_t *
> > > > simple_first_creds_helper(void **credentials,
> > >
> > > This function needs some sort of prefix since it's not static
> > > anymore, doesn't it? Or are the rules for libsvn_subr different?
> >
> > I'm getting compilation failure when these functions are declared as static:
>
> Sure, taking the 'static' away is not a problem. If a function is
> needed in more than one file, it cannot be static.
>
> But functions that aren't static should be called svn_.... something,
> isn't it? So I think you need to rename them.
>
> I'd suggest:
>
> svn_error_t *
> svn_simple_providers_first_creds_helper(void **credentials,
>
Do we want to make this function public?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-26 12:38:04 CEST