Re: svn commit: r30782 - in branches/kwallet/subversion: include libsvn_subr

On Fri, Apr 25, 2008 at 06:18:24AM -0700, arfrever_at_tigris.org wrote:
> Author: arfrever
> Date: Fri Apr 25 06:18:24 2008
> New Revision: 30782
>
> Log:
> On the 'kwallet' branch:

Hey Arfrever,

> + * This is like svn_client_get_simple_provider(), except that the
> + * password is stored in the KWallet.

Shouldn't this be "stored in Kwallet." ?

> @@ -113,7 +89,7 @@ simple_password_set(apr_hash_t *creds,
> CREDENTIALS. PASSWORD_GET is used to obtain the password value.
> PASSTYPE identifies the type of the cached password. CREDENTIALS are
> allocated from POOL. */
> -static svn_error_t *
> +svn_error_t *
> simple_first_creds_helper(void **credentials,

This function needs some sort of prefix since it's not static
anymore, doesn't it? Or are the rules for libsvn_subr different?

> @@ -220,7 +196,7 @@ simple_first_creds_helper(void **credent
> a set of CREDENTIALS to the simple auth provider's username and
> password cache. PASSWORD_SET is used to store the password.
> PASSTYPE identifies the type of the cached password. Allocates from POOL. */
> -static svn_error_t *
> +svn_error_t *
> simple_save_creds_helper(svn_boolean_t *saved,

Same here.

Thanks,

-- 
Stefan Sperling <stsp_at_elego.de>                    Software Monkey
 
German law requires the following banner :(
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                               CEO: Olaf Wagner
 
Store password unencrypted (yes/no)? No