2008-04-25 23:03:17 Stefan Sperling napisał(a):
> On Fri, Apr 25, 2008 at 06:18:24AM -0700, arfrever_at_tigris.org wrote:
> > Author: arfrever
> > Date: Fri Apr 25 06:18:24 2008
> > New Revision: 30782
> >
> > Log:
> > On the 'kwallet' branch:
>
> Hey Arfrever,
>
> > + * This is like svn_client_get_simple_provider(), except that the
> > + * password is stored in the KWallet.
>
> Shouldn't this be "stored in Kwallet." ?
>
> > @@ -113,7 +89,7 @@ simple_password_set(apr_hash_t *creds,
> > CREDENTIALS. PASSWORD_GET is used to obtain the password value.
> > PASSTYPE identifies the type of the cached password. CREDENTIALS are
> > allocated from POOL. */
> > -static svn_error_t *
> > +svn_error_t *
> > simple_first_creds_helper(void **credentials,
>
> This function needs some sort of prefix since it's not static
> anymore, doesn't it? Or are the rules for libsvn_subr different?
I'm getting compilation failure when these functions are declared as static:
/bin/sh ${working_copy}/libtool --tag=CXX --silent --mode=compile g++ ${some_options} -o subversion/libsvn_subr/simple_providers_cpp.lo -c subversion/libsvn_subr/simple_providers_cpp.cpp
subversion/libsvn_subr/simple_providers.h:64: error: ‘svn_error_t* simple_first_creds_helper(void**, void**, void*, apr_hash_t*, const char*, svn_boolean_t (*)(const char**, apr_hash_t*, const char*, const char*, svn_boolean_t, apr_pool_t*), const char*, apr_pool_t*)’ used but never defined
subversion/libsvn_subr/simple_providers.h:82: error: ‘svn_error_t* simple_save_creds_helper(svn_boolean_t*, void*, void*, apr_hash_t*, const char*, svn_boolean_t (*)(apr_hash_t*, const char*, const char*, const char*, svn_boolean_t, apr_pool_t*), const char*, apr_pool_t*)’ used but never defined
http://en.wikibooks.org/wiki/C_Programming/Procedures_and_functions#Static_Functions
These functions need to be called from another file so they shouldn't be static.
> > @@ -220,7 +196,7 @@ simple_first_creds_helper(void **credent
> > a set of CREDENTIALS to the simple auth provider's username and
> > password cache. PASSWORD_SET is used to store the password.
> > PASSTYPE identifies the type of the cached password. Allocates from POOL. */
> > -static svn_error_t *
> > +svn_error_t *
> > simple_save_creds_helper(svn_boolean_t *saved,
>
> Same here.
--
Arfrever Frehtes Taifersar Arahesis
Received on 2008-04-26 01:56:55 CEST