[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]Can we accept JavaHL Revison.Number.Number(-1)?

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Thu, 27 Mar 2008 09:30:54 -0500

Kamesh Jayachandran wrote:
>
>
> David Glasser wrote:
>> On Wed, Mar 26, 2008 at 7:34 AM, Kamesh Jayachandran <kamesh_at_collab.net> wrote:
>>> Hi All,
>>>
>>> I am working on exposing 'svn_client__get_revision_number' in JavaHL.
>>>
>>> I want a equivalent of youngest_rev(in/out param in
>>> svn_client__get_revision_number method).
>>>
>>> Unfortunately our JavaHl does not allow revision numbers to be '-1'.
>> I would think that your change would be confusing, since people
>> familiar with the Subversion API would expect "-1" to be
>> SVN_INVALID_REVNUM.
>
>> Does the JavaHL API really not use an equivalent of SVN_INVALID_REVNUM anywhere?
>
>> Could you just use null?
>
>
> I can use null, but when I want to use an object as In/Out param it
> won't be useful. I need Revison.Number.Number(-1) to know that as an Out
> Param and Revison.Number.Number(ANY_VALID_NUMBER) as an In param.

Do we use in/out params other places in JavaHL? If we need to return
multiple values, it would seem more Java-y to create a new wrapper class
and return that...

-Hyrum

Received on 2008-03-27 15:31:09 CET

This is an archived mail posted to the Subversion Dev mailing list.