[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]Can we accept JavaHL Revison.Number.Number(-1)?

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Thu, 27 Mar 2008 09:27:40 -0500

Kamesh Jayachandran wrote:
>> Well, we don't currently do so anywhere in the C++ side of JavaHL, and
>> I'm just a little leery of getting into that habit. I see the JavaHL
>> bindings as just another consumer of the client API, which just happens
>> to live in our repo; I don't see why it should get special privileges.
>> This is completely orthogonal to the purpose of libsvn_fs_util.
> Well, if it is the case why not promote
> 'svn_client__get_revision_number' to be a public API by renaming it and
> keeping the symbol in subversion/include/svn_client.h?

Well, that's fine, if there's a need for it. I'm against promoting an
API for the sake of promoting an API, though. Looking back at your
proposed JavaHL API, is there a reason why you need to add an API to
JavaHL? Why can't you use info() to get the revision numbers you are
interested in, and do the youngest v. HEAD comparisons in a wrapper?

It's possible that I don't fully grasp what you are trying to do here.


Received on 2008-03-27 15:27:58 CET

This is an archived mail posted to the Subversion Dev mailing list.