Re: hint for improved keyword substitution

On 3/19/08, John Peacock <john.peacock_at_havurah-software.org> wrote:
>
> Mycroft Holmes wrote:
> > if this is a problem, I'll modify my proposal: let the $template$ be
> > slightly customizable.
> > for example instead of replacing "$REV$" with "$REV: nnnn $" I'd like
> > svn to replace "// REV$" with "nnnn // REV: nnnn$"
> > (note that the ": nnnn" part is necessary to match the leftmost "nnnn"
> > in a second pass)
>
>
> This is very C++ biased

it is, but you missed my point: note that I said "let the template be
customizable" and "for example".
maybe I wasn't totally clear, but I meant to show an _example_ of a possible
user customization.

a more flexible keyword engine could solve many problems, including mine.
that's why I propose to change the code... (I vaguely guessed delimiters are
hardcoded to $ :)

I don't want to say "how general" the solution should be -- simply because I
don't know, and in fact I specified only what I'd like to do.

>I suggest that you actually look at the Subversion source code
>(specifically subversion/libsvn_subr/subst.c) and try to come up with a
>more general fix

thanks for pointing it out.

p.s: the standard approach of embedding a keyword string in function is
waaaay limited: more work at
runtime, can't use version numer in preprocessor directives, can't use
in templates... and I'm sure I could list some
more serious limitations
Received on 2008-03-19 18:15:02 CET