[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: hint for improved keyword substitution

From: John Peacock <john.peacock_at_havurah-software.org>
Date: Wed, 19 Mar 2008 09:43:52 -0400

Mycroft Holmes wrote:
> if this is a problem, I'll modify my proposal: let the $template$ be
> slightly customizable.
> for example instead of replacing "$REV$" with "$REV: nnnn $" I'd like
> svn to replace "// REV$" with "nnnn // REV: nnnn$"
> (note that the ": nnnn" part is necessary to match the leftmost "nnnn"
> in a second pass)

This is very C++ biased and won't work for languages that don't support
// as a end-of-line comment. Plus the current code assumes a single
character delimiter on either side of the raw keyword (obviously
currently hardcoded to '$'), so your format would be problematic.

I suggest that you actually look at the Subversion source code
(specifically subversion/libsvn_subr/subst.c) and try to come up with a
more general fix that would resolve situations other than just your own.
  This is a much more likely way that something will get added to the
core code. Lobbing hacks to the current syntax over the wall probably
won't get very far... ;-)

John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-19 14:44:10 CET

This is an archived mail posted to the Subversion Dev mailing list.