[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn log url -rXXX should display proper error message

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Wed, 19 Mar 2008 13:15:36 -0400

"Bhuvaneswaran Arumugam" <bhuvan_at_collab.net> writes:
> [[
> Rename the macro which checks if revision kind is dependent on a WC. Use
> the new macro wherever it is applicable.
>
> * subversion/include/svn_client.h
> (SVN_CLIENT_IS_WC_DEPENDENT_REVKIND): Move this macro ...
> * subversion/libsvn_client/client.h
> (SVN_CLIENT__REVKIND_NEEDS_WC) ... to here and rename it.
> * subversion/libsvn_client/copy.c
> (setup_copy): Use the macro.
> * subversion/libsvn_client/log.c
> (svn_client_log4): Use the new macro.
>
> Suggested by: kfogel
> ]]

Should say it follows up to r29948.

> --- subversion/libsvn_client/client.h (revision 29949)
> +++ subversion/libsvn_client/client.h (working copy)
> @@ -1059,6 +1059,17 @@
> svn_client_ctx_t *ctx,
> apr_pool_t *pool);
>
> +
> +/** Return TRUE iff revision kind is dependent on the working copy.
> + * Otherwise, return FALSE.
> + *
> + * @since New in 1.6.
> + */
> +#define SVN_CLIENT__REVKIND_NEEDS_WC(kind) \
> + ((kind == svn_opt_revision_base || kind == svn_opt_revision_previous || \
> + kind == svn_opt_revision_working || kind == svn_opt_revision_committed) \
> + ? TRUE : FALSE)
> +
>

The uses of "kind" should be "(kind)", that's a super-safe way to write
macros, for reasons you probably remember now that I'm saying it :-).

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-19 18:15:48 CET

This is an archived mail posted to the Subversion Dev mailing list.