Re: [PATCH] Really don't use DSO unless --enable-dso

Eric Gillespie wrote:
> [[[
> Don't try to load DSOs unless configured with --enable-dso.
>
> * configure.ac
> Define SVN_USE_DSO for svn_private_config.h if --enable-dso.
>
> * subversion/libsvn_fs/fs-loader.c
> (load_module): Only try DSOs if SVN_USE_DSO is defined.
>
> * subversion/libsvn_ra/ra_loader.c
> (load_ra_module): Only try DSOs if SVN_USE_DSO is defined.
> ]]]

+1, but wouldn't SVN_USE_DSO imply APR_HAS_DSO? (and that constraint
probably ought to be enforced in configure)

> Index: subversion/libsvn_fs/fs-loader.c
> ===================================================================
> --- subversion/libsvn_fs/fs-loader.c (revision 29243)
> +++ subversion/libsvn_fs/fs-loader.c (working copy)
> @@ -80,7 +80,7 @@
> {
> *initfunc = NULL;
>
> -#if APR_HAS_DSO
> +#if defined(SVN_USE_DSO) && APR_HAS_DSO
> {
> apr_dso_handle_t *dso;
> apr_dso_handle_sym_t symbol;

Max.