Re: [PATCH] Really don't use DSO unless --enable-dso

On Feb 19, 2008 4:28 PM, Eric Gillespie <epg_at_google.com> wrote:
> 1. Install svn 1.X (say 1.3) in /usr/lib (say from your distribution)
>
> 2. Install svn 1.Y (say trunk) in /opt/svnbeta
>
> 3. /opt/svnbeta/bin/svnadmin --version
> subversion/libsvn_subr/version.c:73: (apr_err=200019)
> svnadmin: Version mismatch in 'svn_delta': found 1.6.0-dev, expected 1.4.4
> subversion/libsvn_subr/version.c:73: (apr_err=200019)
> svnadmin: Version mismatch in 'svn_subr': found 1.6.0-dev, expected 1.4.4
>
> What happened? I didn't build with bdb, but Ubuntu did. So I
> have libsvn_fs_base in /usr/lib. When svnadmin --version tries
> to list all backends it knows about, my trunk fs-loader.c calls
> apr_dso_load libsvn_fs_base-1.so.0 without an absolute path, so
> my linker searched my RPATH, found no fs_base, and then searched
> the system search path (naturally including /usr/lib) and found
> fs_base. Of course, when it tries to load that fs_base, it
> freaks out because its dependent libraries are too new. Hmph.
>
> Now, we actually have at least three problems here:
>
> 1. I did not use --enable-dso, so svn should not try to load
> DSOs. I have included a patch to fix this.
>
> 2. If svn loads a too-old ra or fs module, it should unload it
> and move on, not blow up. This may be trivial, impossible, or
> somewhere between; I have no idea. This one is obviated by
> the next one, I think.
>
> 3. We shouldn't be passing a relative path to apr_dso_load.
> Sure, Linux searches various paths when you do that, but other
> systems do not. This does not work on Mac OS X, for example.
> I started working on a patch to fix that a few years ago, but
> lost interest (Mac sucks :) and moved on. This is how httpd
> uses it, too.

It would also be nice if the error named the library or executable
that is doing the search ("svn_fs_base" in your example). I guess
that would need a rev of svn_ver_check_list?

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org