[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: subversion/libsvn_ra/ra_loader.c:934: svn_ra_get_log: Assertion `*path != '/'' failed.

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Sat, 26 Jan 2008 19:18:43 +0000

Olaf Hering wrote:
> On Wed, Jan 23, C. Michael Pilato wrote:
>
>>This should be:
>>
>> $ra->get_log('', 1, $ra->get_latest_revnum, 0, 1, 0, \&log_callback);
>> ^^
>>The script today is in violation of the RA API. Trunk code has been added
>>to catch such violations before they cause problems elsewhere.
>
> The help text needs an update in that case.
>
> subversion/bindings/swig/perl/native/Ra.pm:326

Thanks for pointing out the problem. How's this for a fix?

Log message:
[[[
* subversion/bindings/swig/perl/native/Ra.pm
   (get_log): Correct the perldoc for the $paths parameter, which
     must be '' not '/' to indicate 'all paths'.
]]]

Patch:
[[[
Index: subversion/bindings/swig/perl/native/Ra.pm
===================================================================
--- subversion/bindings/swig/perl/native/Ra.pm (revision 29055)
+++ subversion/bindings/swig/perl/native/Ra.pm (working copy)
@@ -326,7 +326,7 @@
  The first argument can be either a single string or a reference to an
  array of strings. Each of these indicates a path in the repository
  which you are interested in. Revisions which don't change any of these
-paths (or files below them) will be ignored. Simply pass '/' if you don't
+paths (or files below them) will be ignored. Simply pass '' if you don't
  want to limit by path.

  C<$start> and C<$end> should be revision numbers. If C<$start> has a lower
@@ -387,7 +387,7 @@
  showing which paths were changed in each revision, for all revisions starting
  from the first:

- $ra->get_log('/', 1, $ra->get_latest_revnum, 0, 1, 0,
+ $ra->get_log('', 1, $ra->get_latest_revnum, 0, 1, 0,
                   \&log_callback);

      sub log_callback
]]]

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-01-26 20:18:58 CET

This is an archived mail posted to the Subversion Dev mailing list.