[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: UI interpretation quetsions: --changelist + --depth

From: Mark Phippard <markphip_at_gmail.com>
Date: Sat, 26 Jan 2008 15:38:06 -0500

On Jan 26, 2008 12:46 PM, Julian Foad <julianfoad_at_btopenworld.com> wrote:
> Hi Mike and everyone!
> C. Michael Pilato wrote:
> > Karl Fogel wrote:
> >
> >> Ummm, how about:
> >>
> >> For most commands, '--changelist FOO' restricts the scope to items
> >> in the intersection of changelist FOO and the specified (or default)
> >> depth. But for *some* commands, [...]
> >> '--changelist FOO' changes their non-infinity default depth to
> >> infinity, so that the changelist becomes the only restriction when
> >> no depth restriction is explicitly given.
> >>
> >> [...]
> >>
> >> I know people will cry "inconsistency", but I'm not sure consistency
> >> is a major factor in good UI anyway. Meeting intuitive expectations
> >> is more important.
> >>
> >> -Karl
> >
> > [...] perhaps we should just roll with the
> > easy-to-explain "changelist is always a filter, period" explanation. After
> > all, it really isn't so hard to change 'svn info --changelist foo' into
> > 'svn info -R --changelist foo'.
> Er, you what?! If the user issues a command with '--changelist foo' as the only
> file selection criterion, then he/she wants to act on the files in that
> changelist. I can't see any other possible interpretation for 'svn info
> --changelist foo'. The same goes for all subcommands - I've just run through
> them all in my head.
> From a user's point of view, I interpret '--changelist foo' as "act on the
> targets specified in changelist 'foo'", just the same as '--targets foo' means
> "act on the targets specified in file 'foo'". Any default recursion or
> non-recursion that a particular command assumes would come after that step, in
> my head.

FWIW, it sounds like you both are saying it should work the same way.
The part that I suspect Julian was missing was that before you made
this change many of the subcommands were essentially adding what was
in the changelist to what was in CWD which really does not make any
sense. And clearly I think a user expects:

svn info --changelist foo /path

To show the info for the items in /path that belong to changelist foo.
 That is what Julian says it should do and that is what Mike just made
it do with these changes.

Mark Phippard
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-01-26 21:38:22 CET

This is an archived mail posted to the Subversion Dev mailing list.