[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Hook script mailer.py: Allow custom headers in email

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Mon, 07 Jan 2008 12:46:51 -0600

Olav Vitters wrote:
> I have loads (almost 500) repositories going into one mailing list.
> Subscribers can select the repositories they are interested in using the
> Topic feature in mailman. Basically, there is a topic per repository.
> This requires the following header to be set:
> Keywords: <something>
>
> Later on this keyword is matched by mailman.
>
> I'd like to add the keyword header to the hook script mailer.py. As I
> expected such a specific change to be rejected, I've generalized the
> patch a bit.
>
> The patch allows the following:
> [headers]
> keywords = %(project)s
>
>
> Any item defined under [headers] will be added as a custom header.
>
> See attached for a patch. Comments?
> Note: against Subversion 1.4.6. Line numbers will not match exactly due
> to the other patches.

Was this patch made against trunk? I haven't reviewed this, or your
other patches, but your comment about 1.4.6 has me worried. From
HACKING[1]: "Generate the patch using svn diff from the top of a
Subversion trunk working copy."

All patches are applied to trunk, then backported, if needed. If the
patch isn't against trunk, it's not likely to be applied.

(If your patch is against trunk, thanks, and please forgive the
preceding. :) )

-Hyrum

[1] http://subversion.tigris.org/hacking.html#patches

Received on 2008-01-07 19:51:09 CET

This is an archived mail posted to the Subversion Dev mailing list.