[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Hook script mailer.py: Allow custom headers in email

From: Olav Vitters <olav_at_bkor.dhs.org>
Date: Mon, 7 Jan 2008 20:00:42 +0100

On Mon, Jan 07, 2008 at 12:46:51PM -0600, Hyrum K. Wright wrote:
> Olav Vitters wrote:
> > I have loads (almost 500) repositories going into one mailing list.
> > Subscribers can select the repositories they are interested in using the
> > Topic feature in mailman. Basically, there is a topic per repository.
> > This requires the following header to be set:
> > Keywords: <something>
> >
> > Later on this keyword is matched by mailman.
> >
> > I'd like to add the keyword header to the hook script mailer.py. As I
> > expected such a specific change to be rejected, I've generalized the
> > patch a bit.
> >
> > The patch allows the following:
> > [headers]
> > keywords = %(project)s
> >
> >
> > Any item defined under [headers] will be added as a custom header.
> >
> > See attached for a patch. Comments?
> > Note: against Subversion 1.4.6. Line numbers will not match exactly due
> > to the other patches.
>
> Was this patch made against trunk? I haven't reviewed this, or your
> other patches, but your comment about 1.4.6 has me worried. From
> HACKING[1]: "Generate the patch using svn diff from the top of a
> Subversion trunk working copy."

Ah ok, I missed that. I used 1.4.6 as I have that locally plus the
server has 1.3.1 only (meaning, it had to work on that).

I'll check if these apply to trunk and either note that it applies or
regenerate them. Note: please still comment on design issues (if you
think I should've implemented something differently).

> All patches are applied to trunk, then backported, if needed. If the
> patch isn't against trunk, it's not likely to be applied.

I'd like the patches to be in the next Ubuntu LTS release (no idea what
they will use), but it isn't too important. As long as some acceptable
solution goes into trunk.

-- 
Regards,
Olav
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-01-07 20:01:00 CET

This is an archived mail posted to the Subversion Dev mailing list.