[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: static linking broken in trunk since commit of clientstring feature

From: Stefan Kng <tortoisesvn_at_gmail.com>
Date: 2007-12-17 22:12:04 CET

Eric Gillespie wrote:
> =?ISO-8859-1?Q?Stefan_K=FCng?= <tortoisesvn@gmail.com> writes:
>
>> What exactly is 'icky' about moving this to svn_subr?
>
> "Oh, but this one RA interfaces is in svn-subr. Sorry."
>
> Ick.
>
>>> Stefan, care to work up a patch to do this with a new field in
>>> the callback struct?
>> I don't think that will work. Last time I wanted to add something to
>> svn_client_ctx_t and use it in the ra-layers, it didn't work because
>> svn_client_ctx_t is *not* passed down there (at least not as far down as
>> I needed it to). And I don't like to change APIs or introduce a whole
>
> I don't know what you were doing before, but in this case, you're
> just copying the function pointer from the ctx to the callbacks
> in libsvn_client/ra.c:svn_client__open_ra_session_internal .

That's what I mean: the svn_client_ctx_t is not passed down to the ra
layers. For every new entry there another one has to be created in the
svn_ra_callbacks2_t struct. And then the new members of that struct must
be copied yet to another struct (session, connection) to pass those
values further down to where they're actually needed.

Do you really think this is the way to go? Putting that one ra-util
function in svn_subr shouldn't be such a big problem considering the
amount of changes required otherwise.

In case you're wondering what I needed that for last time: I once tried
to implement better progress information callbacks. But since
svn_client_ctx_t is not passed down directly to the other libraries I
gave up after changing two libraries: way too much data copying was
needed for a simple 'global' variable to get incremented in smaller
steps (the progress variable).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 17 22:12:30 2007

This is an archived mail posted to the Subversion Dev mailing list.