[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: static linking broken in trunk since commit of clientstring feature

From: Eric Gillespie <epg_at_pretzelnet.org>
Date: 2007-12-17 21:58:44 CET

=?ISO-8859-1?Q?Stefan_K=FCng?= <tortoisesvn@gmail.com> writes:

> What exactly is 'icky' about moving this to svn_subr?

"Oh, but this one RA interfaces is in svn-subr. Sorry."

Ick.

> > Stefan, care to work up a patch to do this with a new field in
> > the callback struct?
>
> I don't think that will work. Last time I wanted to add something to
> svn_client_ctx_t and use it in the ra-layers, it didn't work because
> svn_client_ctx_t is *not* passed down there (at least not as far down as
> I needed it to). And I don't like to change APIs or introduce a whole

I don't know what you were doing before, but in this case, you're
just copying the function pointer from the ctx to the callbacks
in libsvn_client/ra.c:svn_client__open_ra_session_internal .

-- 
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 17 22:01:27 2007

This is an archived mail posted to the Subversion Dev mailing list.