[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r28502 - in trunk/subversion: libsvn_repos tests/cmdline

From: Eric Gillespie <epg_at_pretzelnet.org>
Date: 2007-12-17 22:11:50 CET

"David Glasser" <glasser@davidglasser.net> writes:

> I like the idea of the change, but I'd start the error message (that
> is, the "action") with a capital letter.

Eh, tomato, tomahto. Done.

> I also suspect you should _(I18Nalize) the action names.

Done.

> And maybe keep the hook names quoted?

Quotes add nothing in this case: we control the file names, they
have no spaces, and there is no ambiguity. They're just more noise.

-- 
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 17 22:12:00 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.