[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: static linking broken in trunk since commit of clientstring feature

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-12-17 21:49:39 CET

Eric Gillespie wrote:
> Eric Gillespie <epg@pretzelnet.org> writes:
>> "David Glasser" <glasser@davidglasser.net> writes:
>>> Some discussion on the IRC channel suggested adding a callback to the
>>> svn_ra_callbacks table, and a field to the svn_client_ctx_t structure,
>>> to allow pushing this data through to the RA layer without needing a
>>> static variable.
>>> This would be much more invasive, of course.
>> I think it's overkill. This is one-time initialization, so it
>> shouldn't be difficult not to call it from multiple threads.
> When I was about to add the note to svn_ra.h that these two
> interfaces are actually in svn-subr, I lost my nerve. It's too
> icky after all.

Sorry for the late reply, I almost missed this thread...

What exactly is 'icky' about moving this to svn_subr?
If you think the static stuff is icky: the same static stuff is used for
the .svn/_svn foldername changes.

> Stefan, care to work up a patch to do this with a new field in
> the callback struct?

I don't think that will work. Last time I wanted to add something to
svn_client_ctx_t and use it in the ra-layers, it didn't work because
svn_client_ctx_t is *not* passed down there (at least not as far down as
I needed it to). And I don't like to change APIs or introduce a whole
lot of new ones (such patches from me have a chance of almost zero to
get committed, so I would just waste my time).

> I'm reverting this in the mean-time.



   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 17 21:53:13 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.