[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: static linking broken in trunk since commit of clientstring feature

From: Eric Gillespie <epg_at_pretzelnet.org>
Date: 2007-12-17 21:33:54 CET

Eric Gillespie <epg@pretzelnet.org> writes:

> "David Glasser" <glasser@davidglasser.net> writes:
>
> > Some discussion on the IRC channel suggested adding a callback to the
> > svn_ra_callbacks table, and a field to the svn_client_ctx_t structure,
> > to allow pushing this data through to the RA layer without needing a
> > static variable.
> >
> > This would be much more invasive, of course.
>
> I think it's overkill. This is one-time initialization, so it
> shouldn't be difficult not to call it from multiple threads.

When I was about to add the note to svn_ra.h that these two
interfaces are actually in svn-subr, I lost my nerve. It's too
icky after all.

Stefan, care to work up a patch to do this with a new field in
the callback struct?

I'm reverting this in the mean-time.

-- 
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 17 21:34:47 2007

This is an archived mail posted to the Subversion Dev mailing list.