[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bindings question: do keyword args make us name-sensitive?

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2007-09-12 09:07:21 CEST

On 9/11/07, Karl Fogel <kfogel@red-bean.com> wrote:
> "David Glasser" <glasser@davidglasser.net> writes:
> > On 9/1/07, kfogel@tigris.org <kfogel@tigris.org> wrote:
> >> Author: kfogel
> >> Date: Sat Sep 1 14:27:45 2007
> >> New Revision: 26419
> >>
> >> Log:
> >> * subversion/include/svn_wc.h
> >> (...many places...): Change 'depth' parameter to 'levels_to_lock',
> >> to avoid confusion with the 'svn_depth_t' sense of "depth".
> >>
> >> Everywhere: Adjust comments and variable / static method names accordingly.
> >
> > A little voice in the back of my head tells me that it's not OK to
> > change parameter names in public APIs, because in some bindings you
> > can use the parameter name as a keyword-style arg in calls. Am I just
> > making that up?
>
> Holy cow. I never thought of that.
>
> I've changed the subject line of this mail to catch the eyes of
> bindings maintainers. I sure hope we can change parameter names in
> the C API... but if we can't, we can't.
>
> If this is an issue only for a few bindings, one possibility is that
> there might be some manual adjustment they could set somewhere, to
> force the arg to use the old name for compatibility. (?)

FWIW, we have had various things in the SWIG bindings break as a
result of that kind of change in the past (I know, I'm the one who
broke them ;-), although it's usually the kind of thing where all of a
sudden some type mappings stop working, someone notices and fixes the
mappings. I don't think we've ever made any conscious decision to
support parameter names as some sort of firm API though, although I
could be mistaken there.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 12 09:03:59 2007

This is an archived mail posted to the Subversion Dev mailing list.