[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r26498 - in branches/svnpatch-diff/subversion: libsvn_client libsvn_wc

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-09-12 02:42:05 CEST

"Charles Acknin" <charlesacknin@gmail.com> writes:
> There's no summary line in this log message. The last two lines were
> supposed to be read like so : "messy '||' and useless sprintf() buggy
> parts found by ...".
>
> Basically, this commit includes both things glasser fixed and things I
> fixed on my side. So I had to write a "selective" 'found by'
> statement, i.e. one that does mention and filter out the parts the
> person was involved in. And the reason this fits in two lines instead
> of one is because it seems the contrib parser
> (tools/dev/contribulyze.py) uses something like "^Found by:" regexp,
> so the line had to begin by one of the field keyword.

Ah. Thanks -- what you want to do is usually done in a parenthetical
aside after the "Found by" line, like so:

   Found by: glasser
   (Just the "messy ||" and "useless sprintf()" parts.)

> I guess we're here discussing this for the sole reason that this
> commit is breaking the "a patch must contain only one logical change"
> rule. I'll make sure I don't make this mistake again in the future.

Well, that would be the ideal, yes :-). But if you do commit a
miscellaneous bunch of changes at once, then there should still be a
summary line saying that's what you've done, so a reader doesn't go
looking for some unifying pattern that isn't there. E.g.:

   Various random and unrelated cleanups:

   * subversion/libsvn_wc/diff.c
   (transmit_svndiff, close_file, change_file_prop, change_dir_prop):
   remove unused variables.

   [...]

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 12 02:38:37 2007

This is an archived mail posted to the Subversion Dev mailing list.