[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r26498 - in branches/svnpatch-diff/subversion: libsvn_client libsvn_wc

From: Charles Acknin <charlesacknin_at_gmail.com>
Date: 2007-09-11 23:32:12 CEST

On 9/11/07, Karl Fogel <kfogel@red-bean.com> wrote:
> cacknin@tigris.org writes:
> > Author: cacknin
> > Date: Sat Sep 8 11:00:26 2007
> > New Revision: 26498
> >
> > Log:
> > * subversion/libsvn_wc/diff.c
> > (transmit_svndiff, close_file, change_file_prop, change_dir_prop):
> > remove unused variables.
> >
> > * subversion/libsvn_client/repos_diff.c
> > (apply_textdelta): remove unused variables.
> >
> > * subversion/libsvn_client/patch.c
> > (get_empty_file): fix messy use of ||
> > (merge_file_added): avoid useless sprintf()
> > (open_directory, add_file, open_file, apply_textdelta,
> > change_file_prop, change_dir_prop): remove unused variables.
> >
> > * subversion/libsvn_client/diff.c
> > (diff_dir_added, diff_dir_deleted): remove unused variables.
> >
> > Messy || and useless sprintf()
> > Found by: glasser
>
> It's better to put the summary line at the start of the log message,
> not the end. That way, the reader can already be in the proper frame
> of mind when reading the detailed part of the log message.

There's no summary line in this log message. The last two lines were
supposed to be read like so : "messy '||' and useless sprintf() buggy
parts found by ...".

Basically, this commit includes both things glasser fixed and things I
fixed on my side. So I had to write a "selective" 'found by'
statement, i.e. one that does mention and filter out the parts the
person was involved in. And the reason this fits in two lines instead
of one is because it seems the contrib parser
(tools/dev/contribulyze.py) uses something like "^Found by:" regexp,
so the line had to begin by one of the field keyword.

I guess we're here discussing this for the sole reason that this
commit is breaking the "a patch must contain only one logical change"
rule. I'll make sure I don't make this mistake again in the future.

Cheers,
Charles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 11 23:28:46 2007

This is an archived mail posted to the Subversion Dev mailing list.