Re: [PATCH (almost)] issue 2429: "svn export" doesn't export svn:externals from local copies

On Tue, Jul 10, 2007 at 01:50:47PM +0300, Vlad Georgescu wrote:
> > Since we now read administrative directories again during export,
> > we also tell svn_wc_adm_probe_open3() not to ignore hidden files
> > anymore.
>
> Huh, I don't know what you mean by that, svn_wc_adm_probe_open3()
> doesn't have such an argument.

Oh, you're right. I must have confused it with svn_wc_entry() which
has a "show hidden files" parameter. My bad.

> > I don't know why this happens.
>
> The test schedules A/B/E for deletion, which immediately removes
> A/B/E/alpha and A/B/E/beta from the working copy. Your patch uses
> svn_io_get_dirents(), which won't be able to find them. This means we
> have to continue using svn_wc_entries_read(), and just copy externals
> explicitly if ignore_externals is FALSE.

Ah, that clears it up. OK, so using svn_io_get_dirents() is really
not an option. And it also seems I misunderstood the behaviour of
svn_wc_entries_read().

> I committed a fix to /trunk in r25707 which solves this issue in the way
> I described.

Thanks very much :)

-- 
Stefan Sperling <stsp@elego.de>                 Software Developer
elego Software Solutions GmbH                            HRB 77719
Ohmstrasse 9                              Tel:  +49 30 40 04 19 29
10179 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                 Geschaeftsfuehrer: Olaf Wagner