Re: JavaHL bindings for the conflict resolution callback API

On 7/10/07, Daniel Rall <dlr@collab.net> wrote:
> > 1) The callback method throws SubversionException. This has to be
> > changed as it is not possible for the implementation of the callback
> > to construct an object of that type. Also, since this is a callback
> > who is responsible for catching this exception? Shouldn't the return
> > value just indicate if there was an error?
>
> SubversionException is a public class with a protected constructor.
> You can create an instance of it via sub-classing. You may be able to
> do this in an ultra light-weight fashion using an anonymous sub-class.

Of course, thanks.

> > 2) What is with all of the usage of Object? Are those just place
> > holders for now and you are going to replace them with new classes you
> > need to create? As a user of the API I have no idea what I am
> > receiving in those parameters -- which seem like important parms, and
> > also I do not know what to return from the callback.
>
> Yup, those are just placeholders for the unimplemented portions of the
> API. I've got a patch in-progress to plug those holes.

OK, thanks. I can wait for you to figure it out.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org