Re: [PATCH] cleanup the neon socket when closing the ra_session

On 7/7/07, Joe Orton <joe@manyfish.co.uk> wrote:
> On Sat, Jul 07, 2007 at 11:21:38AM -0400, mark benedetto king wrote:
> > I wonder if this is the root cause of the double-free problem that Dan
> > Christian described earlier:
>
> Was the version of neon used here built with the OpenSSL thread-safety
> locking callbacks enabled (configure --enable-threadsafe-ssl=posix)?

No, it only had --with-ssl=openssl defined.

I haven't hit the double free problem recently. I am still hitting a
memory pool corruption problem that happens on shutdown.

<rant>
How the @#@# was I supposed to know that should be defined? I've had
more problems building svn due to poorly documented support library
configuration requirements than any package I've ever worked with
before. The other big one was insuring that serf was truly built for
the apr that svn is running with.

Threading support in particular is a mixed message. There is nothing
that says what has to be done for threaded programs using libsvn* (and
supporting libraries). There are hints that people have thought about
threading issues, but no definitive statement.

Can't we do some kind of (possibly optional) run time checks against
support library configuration?

Sorry for the rant, but I've been bitten by this too many times.
</rant>

I'm happy to test different configurations, but I need an explicit patch.

-Dan C

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 9 18:34:47 2007