[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] cleanup the neon socket when closing the ra_session

From: Joe Orton <joe_at_manyfish.co.uk>
Date: 2007-07-07 23:39:33 CEST

On Sat, Jul 07, 2007 at 11:21:38AM -0400, mark benedetto king wrote:
> On Fri, Jul 06, 2007 at 09:03:31PM +0100, Joe Orton wrote:
> > (Looking at the code, ra_dav should really just call ne_sock_init() once
> > in svn_ra_dav__init, I think; it's unnecessary/wrong to call it each
> > time an RA session is opened.)
>
> I'm leaning towards "wrong", since ne_sock_init doesn't serialize its
> access to the init_state counter.
>
> I wonder if this is the root cause of the double-free problem that Dan
> Christian described earlier:

Was the version of neon used here built with the OpenSSL thread-safety
locking callbacks enabled (configure --enable-threadsafe-ssl=posix)?

joe

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 7 23:39:22 2007

This is an archived mail posted to the Subversion Dev mailing list.