[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25607 - trunk/subversion/tests/cmdline

From: David Glasser <glasser_at_mit.edu>
Date: 2007-07-02 23:30:56 CEST

On 7/2/07, Daniel Rall <dlr@collab.net> wrote:
> On Mon, 02 Jul 2007, David Glasser wrote:
>
> > On 7/1/07, Lieven Govaerts <svnlgo@mobsol.be> wrote:
> > >glasser@tigris.org wrote:
> ...
> > >> --- trunk/subversion/tests/cmdline/commit_tests.py (original)
> > >> +++ trunk/subversion/tests/cmdline/commit_tests.py Sun Jul 1
> > >14:47:54 2007
> ...
> > >> - expected_output = [ "Sending "+ iota_path + "\n",
> > >> - "Transmitting file data .\n",
> > >> - "Committed revision 2.\n",
> > >> - "\n",
> > >> - "Warning: 'post-commit' hook failed (exited with
> > >a "
> > >> - "non-zero exitcode of 1). The following error
> > >output "
> > >> - "was produced by the hook:\n",
> > >> - "Post-commit hook failed\n",
> > >> - ]
> > >> -
> > >> + expected_output = "Post-commit hook failed"
> > >> +
> > >> svntest.actions.run_and_verify_svn(None, expected_output, [],
> > >> 'ci', '-m', 'log msg', iota_path)
> > >>
> > >David,
> > >
> > >while I have no problem with the idea of changing 1.4 tests to pass with
> > >a trunk server, in this case we loose the part that tests the fix for
> > >issue 2648.
> > >So I'm negative on this change.
> >
> > Hmm, OK. My impression was that the main point of the test was to
> > make sure that the post-commit hook is called at all and that the
> > warning text comes through; the 2648 change (r22494) is just a detail.
> >
> > Do you agree that this should be backported even if it isn't
> > appropriate on trunk?
>
> I'm not a big fan on this on trunk, but do think it makes sense to
> backport.

OK. I will revert it on trunk, but still support its backporting; the
specific issue will be solved in a different way once I introduce
--server-minor-version.

--dave

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 2 23:30:47 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.