[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25607 - trunk/subversion/tests/cmdline

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-07-02 22:36:37 CEST

On Mon, 02 Jul 2007, David Glasser wrote:

> On 7/1/07, Lieven Govaerts <svnlgo@mobsol.be> wrote:
> >glasser@tigris.org wrote:
...
> >> --- trunk/subversion/tests/cmdline/commit_tests.py (original)
> >> +++ trunk/subversion/tests/cmdline/commit_tests.py Sun Jul 1
> >14:47:54 2007
...
> >> - expected_output = [ "Sending "+ iota_path + "\n",
> >> - "Transmitting file data .\n",
> >> - "Committed revision 2.\n",
> >> - "\n",
> >> - "Warning: 'post-commit' hook failed (exited with
> >a "
> >> - "non-zero exitcode of 1). The following error
> >output "
> >> - "was produced by the hook:\n",
> >> - "Post-commit hook failed\n",
> >> - ]
> >> -
> >> + expected_output = "Post-commit hook failed"
> >> +
> >> svntest.actions.run_and_verify_svn(None, expected_output, [],
> >> 'ci', '-m', 'log msg', iota_path)
> >>
> >David,
> >
> >while I have no problem with the idea of changing 1.4 tests to pass with
> >a trunk server, in this case we loose the part that tests the fix for
> >issue 2648.
> >So I'm negative on this change.
>
> Hmm, OK. My impression was that the main point of the test was to
> make sure that the post-commit hook is called at all and that the
> warning text comes through; the 2648 change (r22494) is just a detail.
>
> Do you agree that this should be backported even if it isn't
> appropriate on trunk?

I'm not a big fan on this on trunk, but do think it makes sense to
backport.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 2 22:36:27 2007

This is an archived mail posted to the Subversion Dev mailing list.