Re: svn commit: r25517 - in trunk/subversion: include libsvn_client
On Sat, Jun 23, 2007 at 11:45:34AM -0700, email@example.com wrote:
> Fix backwards compatibility issue with svn_client_status2.
> --- trunk/subversion/include/svn_types.h (original)
> +++ trunk/subversion/include/svn_types.h Sat Jun 23 11:45:34 2007
> @@ -300,6 +300,20 @@
> #define SVN_DEPTH_FROM_RECURSE(recurse) \
> ((recurse) ? svn_depth_infinity : svn_depth_files)
> +/* Return an @c svn_depth_t depth based on boolean @a recurse.
> + * Use this only for the status command, as it has a unique interpretation
> + * of recursion.
> + *
> + * @note New code should never need to use this, it is called only
> + * from pre-depth APIs, for compatibility.
> + *
> + * @since New in 1.5.
> + */
> +#define SVN_DEPTH_FROM_RECURSE_STATUS(recurse) \
> + ((recurse) ? svn_depth_infinity : svn_depth_immediates)
It strikes me that a public macro that says "don't use this" isn't
particularly useful to other users of the API. Is there any reason not
to just inline the definition into the single place it's used?
Received on Tue Jun 26 15:54:44 2007
- application/pgp-signature attachment: stored
This is an archived mail posted to the Subversion Dev