Re: svn commit: r25542 - trunk/subversion/mod_dav_svn/reports

On Tue, Jun 26, 2007 at 05:15:10AM -0700, kameshj@tigris.org wrote:
> Operational logging enhancements:
> Log 'replay' command like other commands 'command path revision'.

(That log message could be a little clearer, maybe something like
"Change the format of the 'replay' command to match other commands:
'command path revision'"?).

> action = apr_psprintf(resource->info->r->pool,
> - "replay %ld '%s'", rev,
> + "replay '%s' r%" SVN_REVNUM_T_FMT,

I thought we'd effectively deprecated SVN_REVNUM_T_FMT? On checking, I
see there's a message about not using it within gettext() strings (which
doesn't apply here), so I'm not sure.

Anyone: are we supposed to use SVN_REVNUM_T_FMT in new code?

> - action = apr_psprintf(resource->info->r->pool, "replay %ld", rev);
> + action = apr_psprintf(resource->info->r->pool, "replay r%" SVN_REVNUM_T_FMT, rev);

Long line, please fix.

Regards,
Malcolm