[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25542 - trunk/subversion/mod_dav_svn/reports

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-06-26 15:59:08 CEST

On Tue, Jun 26, 2007 at 05:15:10AM -0700, kameshj@tigris.org wrote:
> Operational logging enhancements:
> Log 'replay' command like other commands 'command path revision'.

(That log message could be a little clearer, maybe something like
"Change the format of the 'replay' command to match other commands:
'command path revision'"?).

> action = apr_psprintf(resource->info->r->pool,
> - "replay %ld '%s'", rev,
> + "replay '%s' r%" SVN_REVNUM_T_FMT,

I thought we'd effectively deprecated SVN_REVNUM_T_FMT? On checking, I
see there's a message about not using it within gettext() strings (which
doesn't apply here), so I'm not sure.

Anyone: are we supposed to use SVN_REVNUM_T_FMT in new code?

> - action = apr_psprintf(resource->info->r->pool, "replay %ld", rev);
> + action = apr_psprintf(resource->info->r->pool, "replay r%" SVN_REVNUM_T_FMT, rev);

Long line, please fix.


  • application/pgp-signature attachment: stored
Received on Tue Jun 26 15:58:46 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.