[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] javahl using microsecond time in LogMessage

From: Blair Zajac <blair_at_orcaware.com>
Date: 2007-04-18 03:36:14 CEST

Mark Phippard wrote:
> On 4/17/07, Blair Zajac <blair@orcaware.com> wrote:
>> Well, depending upon the usage, we could be constructing a bunch of them
>> every time the date is needed.
>>
>> How about setting the date field to null upon construction for the new
>> constructor and then when it's first requested, we calculate the date
>> and cache it.
>>
>> Here's a patch that does that.
>>
>> I realized that the part of this patch that changes everything but the
>> LogMessage is safe to commit, so I'll probably do that shortly. The
>> change the LogMessage can be separate, depending upon what we decide
>> here.
>
> That is a good point. I would go ahead with the new patch.

Committed in r24625.

Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 18 03:36:27 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.