Re: [PATCH] Don't waste some APR file buffers
On Mon, Apr 16, 2007 at 04:40:43PM -0700, Daniel Rall wrote:
> On Mon, 16 Apr 2007, Eric Gillespie wrote:
> > Daniel Rall <email@example.com> writes:
> > > +1, this patch does what's intended. We're sure there's no unexpected
> > > side-effects from this?
> > We're sure it passes the tests. I obviously can't say with
> > certainty that there are no unexpected side effects, but all
> > we're doing is dropping the buffer, which is just an optimization
> > to reduce the number of reads and writes. It's actually a
> > de-optimization (mediocritization? :) for files as tiny as these.
> Right. Commit it.
-1, sorry. Check the implementation of svn_io_read_length_line() - it
reads the file byte-by-byte.
Received on Tue Apr 17 11:23:31 2007
- application/pgp-signature attachment: stored
This is an archived mail posted to the Subversion Dev