[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Don't waste some APR file buffers

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-04-17 01:40:43 CEST

On Mon, 16 Apr 2007, Eric Gillespie wrote:

> Daniel Rall <dlr@collab.net> writes:
> > +1, this patch does what's intended. We're sure there's no unexpected
> > side-effects from this?
> We're sure it passes the tests. I obviously can't say with
> certainty that there are no unexpected side effects, but all
> we're doing is dropping the buffer, which is just an optimization
> to reduce the number of reads and writes. It's actually a
> de-optimization (mediocritization? :) for files as tiny as these.

Right. Commit it.

  • application/pgp-signature attachment: stored
Received on Tue Apr 17 01:42:31 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.