[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Is mod_dav_svn safe for use in a threaded MPM?

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-04-17 11:23:41 CEST

On Mon, Apr 16, 2007 at 02:22:18PM -0700, Eric Gillespie wrote:
> + err = svn_io_file_open(&activity_file, pathname, APR_READ,
> + APR_OS_DEFAULT, iterpool);
> ...
> + err = svn_io_read_length_line(activity_file, txn_name, &len, NULL);

Now that you're using svn_io_read_length_line() rather than reading the
whole file in one go, you _should_ be using APR_BUFFERED :-)

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Tue Apr 17 11:24:55 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.