[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "SVNAuthorizationShortCircuit or something similar"

From: Josh Gilkerson <jwg_at_google.com>
Date: 2007-04-12 21:19:00 CEST

When we can do the lookup was one question that I had. Is it
guaranteed that the authz register_hooks(where the provider is
registered) is called before the dav configuration? Or should I be
registering the provider somewhere else?

In the patch, I do the lookup each time because it seemed the safest
thing to do without knowing the order of these calls and it should be
fast.

On 4/12/07, Justin Erenkrantz <justin@erenkrantz.com> wrote:
>
> Without looking at Josh's patch, you should be able to do the provider
> lookup at config time (2 hash tables lookups) and then you'd invoke
> the function pointer each time. So, it should be the same as a
> regular function call. The point is that you are bypassing Apache's
> sub-req creation overhead which is why the performance can suck. It
> should reduce to an identical call profile as artem's approach, but
> keeping the modules distinct. -- justin
>

-- 
Josh Gilkerson
Software Engineer
Google, Inc · MV-1600 Plymouth (HQ)
+1 (650) 253-1667 direct
+1 (859) 608-7827 cell
jwg@google.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 12 21:19:19 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.